rename to CLOSE_STREAM, make error code optional #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
close-stream
branch
from
a3a1269
to
dbe188b
Compare
marten-seemann
force-pushed
the
close-stream
branch
from
dbe188b
to
af38608
Compare
kazuho
reviewed
Jun 2, 2023
There was a problem hiding this comment.
@marten-seemann Thank you for your efforts. Looks good modulo the points below.
Co-authored-by: Kazuho Oku <kazuhooku@gmail.com>
|
Thank you @kazuho! |
Closed
| Stream ID (i), | ||
| Application Protocol Error Code (i), | ||
| [Application Protocol Error Code (i)], |
There was a problem hiding this comment.
I would prefer if this were unconditional. A value of 0 (or whatever application error equates to no error) is fine.
I see why you made this choice, but if the goal is to send STREAM+FIN, then STREAM+FIN exists. This frame only makes sense if reliable size < final size.
| # Resetting Streams | ||
| ## Without an Error | ||
|
|
||
| When closing a stream with an error, the node has the choise between a STREAM |
| The CLOSE_STREAM frame can be used to reduce the reliable offset after a | ||
| STREAM frame with a FIN bit has been sent. If STREAM frames containing data | ||
| up to that byte offset are lost, the initiator MUST retransmit this data, as | ||
| described in (Section 13.3 of {{!RFC9000}}). Data sent beyond that byte offset |
There was a problem hiding this comment.
{{Section 13.3 of !RFC9000}}
| frame and a RELIABLE_RESET_STREAM frame. When using a RESET_STREAM frame, the | ||
| behavior is unchanged from the behavior described in ({{!RFC9000}}). | ||
| frame and a CLOSE_STREAM frame of type 0x21. When using a RESET_STREAM frame, | ||
| the behavior is unchanged from the behavior described in ({{!RFC9000}}). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stab at renaming to CLOSE_STREAM. I'm pretty sure this requires more cleanup.
Introducing a variant without an error code creates a lot of complication, since this is now an alternative to a STREAM frame with a FIN bit.