Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for L10 and L11 metadata for XML generation #85

Closed
quietvoid opened this issue Dec 24, 2021 · 4 comments
Closed

Support for L10 and L11 metadata for XML generation #85

quietvoid opened this issue Dec 24, 2021 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@quietvoid
Copy link
Owner

If anyone is interested in this, I'm missing XML file samples that contain L10 or L11 metadata.

@quietvoid quietvoid added the help wanted Extra attention is needed label Dec 24, 2021
@saindriches
Copy link
Contributor

Doing some guesswork about this, found something makes the color primaries related blocks (L9 L10) a bit complex to generate. L10 depends on custom target display, which is a normal TargetDisplay node with ID other than pre-defined IDs. Since it appears in 5.1.0 (5.0.0 actually, which is a beta version), ApplicationType is also present. Encoder only generates trim blocks of HOME type targets. Still finding more rules with verifier.
L11 metadata does not appear before XML version 5.1.0, and it should be like this:

              ......
            </DVGlobalData>
            <Level11 level="11">
              <ContentType>arg1</ContentType>
              <IntendedWhitePoint>arg2</IntendedWhitePoint>
            </Level11>
            <Level 254 level="254">
              ......

arg1 [0-4]
arg2 [0-15]

It's together with L254. No other big difference between 5.1.0 and 4.0.2, but we need check XML version with number to handle more versions correctly. I'm doing a naive implementation, will make a draft pr later.

@quietvoid
Copy link
Owner Author

I've not yet bothered with versions from the XML but we should probably be using the L254 from it, as long as DM version stays 2.

quietvoid added a commit that referenced this issue Jan 7, 2022
Add support for variable length extension metadata blocks.
And improve generating from XML to support the new metadata.

Fixes #104
Fixes #105 

Partial implementation of #85, for L10 metadata generation from XML.
@quietvoid
Copy link
Owner Author

L10 is now generated from target displays in the XML.
Gonna add L11 now.

@quietvoid
Copy link
Owner Author

We're still not able to do a comparison with the XML for L11, so still unclear whether it's correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants