-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for L10 and L11 metadata for XML generation #85
Comments
Doing some guesswork about this, found something makes the color primaries related blocks (L9 L10) a bit complex to generate. L10 depends on custom target display, which is a normal TargetDisplay node with ID other than pre-defined IDs. Since it appears in 5.1.0 (5.0.0 actually, which is a beta version), ApplicationType is also present. Encoder only generates trim blocks of HOME type targets. Still finding more rules with verifier.
arg1 [0-4] It's together with L254. No other big difference between 5.1.0 and 4.0.2, but we need check XML version with number to handle more versions correctly. I'm doing a naive implementation, will make a draft pr later. |
I've not yet bothered with versions from the XML but we should probably be using the L254 from it, as long as DM version stays 2. |
L10 is now generated from target displays in the XML. |
We're still not able to do a comparison with the XML for L11, so still unclear whether it's correct. |
If anyone is interested in this, I'm missing XML file samples that contain L10 or L11 metadata.
The text was updated successfully, but these errors were encountered: