Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test quilc endpoints #288

Merged
merged 11 commits into from
Jun 24, 2019
Merged

Test quilc endpoints #288

merged 11 commits into from
Jun 24, 2019

Conversation

notmgsk
Copy link
Member

@notmgsk notmgsk commented Jun 14, 2019

quilc endpoints are mostly untested, which allowed a bug to creep in (see #287).

The tests here could be better, if I knew more about cliffords etc.

@notmgsk notmgsk requested a review from a team as a code owner June 14, 2019 01:46
ecpeterson
ecpeterson approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@ecpeterson ecpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you don't want to expand the scope of the PR, but I left a robustness suggestion if you don't mind expanding a little bit.

Before merging this, I'd like to get CI/CD back up, which we can talk about offline.

appleby
appleby reviewed Jun 14, 2019
View reviewed changes
Copy link
Contributor

@appleby appleby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so good to me

src/package.lisp Outdated Show resolved Hide resolved
@notmgsk notmgsk requested a review from ecpeterson June 14, 2019 17:21
appleby
appleby reviewed Jun 14, 2019
View reviewed changes
src/package.lisp Outdated Show resolved Hide resolved
@appleby appleby mentioned this pull request Jun 17, 2019
Merged
@notmgsk notmgsk mentioned this pull request Jun 17, 2019
Merged
3 tasks
@notmgsk notmgsk mentioned this pull request Jun 21, 2019
Merged
@notmgsk
Copy link
Member Author

notmgsk commented Jun 21, 2019

Tests fail still because quicklisp's QVM is still a point-release behind.

@stylewarning stylewarning merged commit 4e37e2b into master Jun 24, 2019
@stylewarning stylewarning deleted the fix/test-quilc-endpoints branch June 24, 2019 19:01
@notmgsk notmgsk mentioned this pull request Jul 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleby appleby appleby left review comments

@stylewarning stylewarning stylewarning approved these changes

@ecpeterson ecpeterson Awaiting requested review from ecpeterson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@notmgsk @appleby @stylewarning @ecpeterson