Bugfix: rework some of the standard gates init logic to accommodate seq gates #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spin1Half
changed the title
stylewarning
requested changes
Apr 8, 2022
Spin1Half
force-pushed
the
bugfix-resolve-validate-seq-std-gates
branch
from
07e47ea
to
c5601f3
Compare
Spin1Half
force-pushed
the
bugfix-resolve-validate-seq-std-gates
branch
from
c5601f3
to
b71ead8
Compare
|
This was in draft because of issues I was encountering for an unrelated reason, I will address these issues in a separate PR |
stylewarning
requested changes
Apr 21, 2022
src/initialize-standard-gates.lisp
Outdated
| (parsed-program-gate-definitions parsed-program))) | ||
|
|
||
| (unless (boundp' **default-gate-definitions**) | ||
| (eval-when (:compile-toplevel :load-toplevel :execute) |
There was a problem hiding this comment.
I think this eval-when needs to be on the outside
also please write a comment above this block of code to explain what it's doing anx why it's here. It's unusual to see toplevel code getting evaluated like this.
Lastly, I would wrap this stuff in a function itself, and do the eval-when stuff around a call to it.
(eval-when (...)
(defun read-standard...)
(defun initialize-standard-gate-definitions...)
(initialize-standard-gate-definitions)
) ; eval-when
There was a problem hiding this comment.
Implemented the structural changes.
Did my best to explain what was going on, but I don't know that I was as informative as I could be
Spin1Half
force-pushed
the
bugfix-resolve-validate-seq-std-gates
branch
from
b71ead8
to
3ba4154
Compare
Spin1Half
force-pushed
the
bugfix-resolve-validate-seq-std-gates
branch
from
3ba4154
to
09d7ad7
Compare
src/initialize-standard-gates.lisp
Outdated
| (setf (gethash (gate-definition-name gate-def) table) | ||
| gate-def))))))) | ||
|
|
||
| (initialize-standard-gates));eval-when |
There was a problem hiding this comment.
Suggested change
| (initialize-standard-gates));eval-when | |
| (initialize-standard-gates) | |
| ) ; eval-when |
Spin1Half
force-pushed
the
bugfix-resolve-validate-seq-std-gates
branch
from
09d7ad7
to
af48e69
Compare
Spin1Half
force-pushed
the
bugfix-resolve-validate-seq-std-gates
branch
from
af48e69
to
19f2863
Compare
stylewarning
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered when fiddling with some of the std gate definitions that the recent sequence gate definition validation/resolution aren't fully integrated for sequence gate definitions added to this file