Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DQVM: mpi sync overload #19

Closed
lcapelluto opened this issue Jan 30, 2019 · 1 comment
Closed

DQVM: mpi sync overload #19

lcapelluto opened this issue Jan 30, 2019 · 1 comment
Assignees
@jmbr

Comments

@lcapelluto
Copy link

It's possible we have superfluous syncs. There are the right number between master and worker nodes. However, it's still worth digging deeper. I think it may be possible to remove at least one pair of syncs. Also: there is a sync in reorganize-amplitudes, (and execute-instruction, calls reorganize-amplitudes). It would be better to keep all the syncs in the main loop for both worker and master.
@jmbr jmbr self-assigned this Jun 28, 2019
@jmbr
Copy link
Contributor

jmbr commented Jun 28, 2019

Indeed. At least one pair was redundant.

@jmbr jmbr mentioned this issue Sep 6, 2019
Merged
@jmbr jmbr closed this as completed Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmbr jmbr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmbr @lcapelluto