-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow fatal SBCL errors to be caught #54
Open
kartik-s
wants to merge
57
commits into
add-ci
Choose a base branch
from
catch-fatal-errors
base: add-ci
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macrologist
reviewed
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a first pass. I didn't try to understand what it is doing.
kartik-s
force-pushed
the
catch-fatal-errors
branch
5 times, most recently
from
April 18, 2024 20:41
8d3f788
to
30991ab
Compare
kartik-s
force-pushed
the
catch-fatal-errors
branch
4 times, most recently
from
May 12, 2024 19:39
656f7a8
to
c096346
Compare
kartik-s
force-pushed
the
catch-fatal-errors
branch
from
May 13, 2024 17:45
c096346
to
551dae5
Compare
kartik-s
force-pushed
the
catch-fatal-errors
branch
2 times, most recently
from
June 12, 2024 18:19
ff80900
to
bda3d3c
Compare
kartik-s
force-pushed
the
catch-fatal-errors
branch
from
June 21, 2024 04:29
3e747a9
to
be8a5a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A call into Lisp may trigger a fatal error in SBCL, dropping the process unceremoniously into LDB and making it difficult for the user to gracefully terminate the process.
Solution
Use
setjmp
to save the execution context before calling into Lisp, and uselongjmp
to return to the pre-call execution context with a special error code if a fatal SBCL error was encountered.Notes
lossage_handler
function pointer non-static, settingsbcl-librarian::*non-static-lossage-handler*
toT
, and adding afatal-error
code to the error map.DEFINE-ERROR-TYPE
takes a newfatal-error
argument specifying which value to return when a Lisp call triggers a fatal SBCL error.setjmp
before calling into Lisp through the associated function pointer.error-map
or nofatal-code
is specified, then the fatal error handler just drops into LDB.