add lodash merge to replace extend

quilljs · Apr 15, 2020 · 0810718 · 0810718
1 parent 2e2bc93
commit 0810718
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 19 deletions.
diff --git a/core/editor.js b/core/editor.js
@@ -1,6 +1,6 @@
-import extend from 'extend';
 import cloneDeep from 'lodash.clonedeep';
 import isEqual from 'lodash.isequal';
+import merge from 'lodash.merge';
 import Delta, { AttributeMap } from 'quill-delta';
 import { LeafBlot } from 'parchment';
 import { Range } from './selection';
@@ -42,10 +42,10 @@ class Editor {
           }
           this.scroll.insertAt(index, text);
           const [line, offset] = this.scroll.line(index);
-          let formats = extend({}, bubbleFormats(line));
+          let formats = merge({}, bubbleFormats(line));
           if (line instanceof Block) {
             const [leaf] = line.descendant(LeafBlot, offset);
-            formats = extend(formats, bubbleFormats(leaf));
+            formats = merge(formats, bubbleFormats(leaf));
           }
           attributes = AttributeMap.diff(formats, attributes) || {};
         } else if (typeof op.insert === 'object') {

diff --git a/core/quill.js b/core/quill.js
@@ -1,7 +1,7 @@
 import Delta from 'quill-delta';
 import cloneDeep from 'lodash.clonedeep';
+import merge from 'lodash.merge';
 import * as Parchment from 'parchment';
-import extend from 'extend';
 import Editor from './editor';
 import Emitter from './emitter';
 import Module from './module';
@@ -458,8 +458,7 @@ Quill.imports = {
 };
 
 function expandConfig(container, userConfig) {
-  userConfig = extend(
-    true,
+  userConfig = merge(
     {
       container,
       modules: {
@@ -514,8 +513,7 @@ function expandConfig(container, userConfig) {
       container: userConfig.modules.toolbar,
     };
   }
-  userConfig = extend(
-    true,
+  userConfig = merge(
     {},
     Quill.DEFAULTS,
     { modules: moduleConfig },

diff --git a/modules/clipboard.js b/modules/clipboard.js
@@ -1,4 +1,3 @@
-import extend from 'extend';
 import Delta from 'quill-delta';
 import {
   Attributor,
@@ -219,10 +218,8 @@ function applyFormat(delta, format, value) {
     if (op.attributes && op.attributes[format]) {
       return newDelta.push(op);
     }
-    return newDelta.insert(
-      op.insert,
-      extend({}, { [format]: value }, op.attributes),
-    );
+    const formats = value ? { [format]: value } : {};
+    return newDelta.insert(op.insert, { ...formats, ...op.attributes });
   }, new Delta());
 }
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -36,6 +36,7 @@
     "extend": "^3.0.2",
     "lodash.clonedeep": "^4.5.0",
     "lodash.isequal": "^4.5.0",
+    "lodash.merge": "^4.5.0",
     "parchment": "2.0.0-dev.2",
     "quill-delta": "4.2.1"
   },

diff --git a/themes/base.js b/themes/base.js
@@ -1,4 +1,4 @@
-import extend from 'extend';
+import merge from 'lodash.merge';
 import Emitter from '../core/emitter';
 import Theme from '../core/theme';
 import ColorPicker from '../ui/color-picker';
@@ -151,7 +151,7 @@ class BaseTheme extends Theme {
     this.quill.on(Emitter.events.EDITOR_CHANGE, update);
   }
 }
-BaseTheme.DEFAULTS = extend(true, {}, Theme.DEFAULTS, {
+BaseTheme.DEFAULTS = merge({}, Theme.DEFAULTS, {
   modules: {
     toolbar: {
       handlers: {

diff --git a/themes/bubble.js b/themes/bubble.js
@@ -1,4 +1,4 @@
-import extend from 'extend';
+import merge from 'lodash.merge';
 import Emitter from '../core/emitter';
 import BaseTheme, { BaseTooltip } from './base';
 import { Range } from '../core/selection';
@@ -107,7 +107,7 @@ class BubbleTheme extends BaseTheme {
     this.buildPickers(toolbar.container.querySelectorAll('select'), icons);
   }
 }
-BubbleTheme.DEFAULTS = extend(true, {}, BaseTheme.DEFAULTS, {
+BubbleTheme.DEFAULTS = merge({}, BaseTheme.DEFAULTS, {
   modules: {
     toolbar: {
       handlers: {

diff --git a/themes/snow.js b/themes/snow.js
@@ -1,4 +1,4 @@
-import extend from 'extend';
+import merge from 'lodash.merge';
 import Emitter from '../core/emitter';
 import BaseTheme, { BaseTooltip } from './base';
 import LinkBlot from '../formats/link';
@@ -103,7 +103,7 @@ class SnowTheme extends BaseTheme {
     }
   }
 }
-SnowTheme.DEFAULTS = extend(true, {}, BaseTheme.DEFAULTS, {
+SnowTheme.DEFAULTS = merge({}, BaseTheme.DEFAULTS, {
   modules: {
     toolbar: {
       handlers: {