Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Cannot read property 'parentNode' of null" error thrown when removing format #310

Closed
dandirks opened this issue Mar 18, 2015 · 1 comment · Fixed by #311
Closed

"Cannot read property 'parentNode' of null" error thrown when removing format #310

dandirks opened this issue Mar 18, 2015 · 1 comment · Fixed by #311

Comments

@dandirks
Copy link

Platform: OSX 10.10.2
Browser: Chrome 41.0.2272.89

Steps to reproduce:

  1. Go to http://quilljs.com/examples/
  2. Delete all of the text out of the first example.
  3. Type "This is a test." in the editor.
  4. Apply bold to the word "This"
  5. Apply italic to the word "This"
  6. Apply bold to the entire line.
  7. Remove bold from the entire line.

Chrome should now throw Uncaught TypeError: Cannot read property 'parentNode' of null at quill.js:5026.

Let me know if I need to provide additional information.

Thanks!
thomsbg added a commit to voxmedia/quill that referenced this issue Mar 19, 2015
@thomsbg
Ensure targetNode matches leaf.length in formatText
f855771 
Without this call to split(), the targetNode may outgrow leaf.length, causing
the call to format.add(targetNode, value) to operate on more than was intended.

Fixes slab#310
@thomsbg thomsbg mentioned this issue Mar 19, 2015
Merged
@thomsbg
Copy link
Contributor

thomsbg commented Mar 19, 2015

Thanks for the clear repro steps! I was experiencing this error also, but could not pin it down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure targetNode matches leaf.length in formatText voxmedia/quill
2 participants
@thomsbg @dandirks