Convert newlines between inline elements to a space #3983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, if you paste the following HTML, the newline between the `<span>` elements is incorrectly discarded. ```html <span>foo</span> <span>bar</span> ``` This will currently insert `foobar` into Quill, when we'd expect `foo bar`, since newlines should [treated as spaces][1] between inline elements (such as `<span>`). This change updates the `matchText()` clipboard matcher to check if the text node is between inline elements or not before early-returning. [1]: https://developer.mozilla.org/en-US/docs/Web/API/Document_Object_Model/Whitespace
luin
force-pushed
the
clipboard-inline
branch
from
0a745ee
to
f777637
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, if you paste the following HTML, the newline between the
<span>elements is incorrectly discarded.This will currently insert
foobarinto Quill, when we'd expectfoo bar, since newlines should treated as spaces between inline elements (such as<span>).This change updates the
matchText()clipboard matcher to check if the text node is between inline elements or not before early-returning.