Fix #107 (display read/edit mode FAB also if note has empty title) #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display read/edit mode FAB also if note has empty title
nofishonfriday
force-pushed
the
fix-show-read-edit-fab-empty-title
branch
from
c003f6a
to
08c2238
Compare
jsixface
requested changes
Apr 5, 2023
jsixface
approved these changes
Apr 6, 2023
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo:
Additionally there's a slight change in behaviour when user re-edits content of an untitled note.
Previously it would set focus to the title, but it seems to make more sense if focus is set to content in this case imo (seen at end of the gif).
But this can be reverted if wanted. :)