-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User macros #69
Merged
Merged
User macros #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be115ee
to
0ccf646
Compare
|
SamWilsn
reviewed
Aug 29, 2021
b04d045
to
9028c26
Compare
db2da40
to
8f28772
Compare
ef1b3b8
to
1b7fd90
Compare
SamWilsn
reviewed
Sep 22, 2021
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
All feedback addressed, PTAL! 😃 |
SamWilsn
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following new features:
Expressions
Doing arithmetic on push data is a desirable attribute of an assembler.
While constant expressions may improve readability, they aren't that useful. The big win is doing arithmetic on label addresses.
Any normal operand type is available as an expression term!
Expression Macros
Expressions significantly improve the usability of
eas
. Now that we have a rich format for expressing mathematical expressions, it would be great if we could reuse those expressions.Instruction Macros
Instruction macros take things a step further. While expression macros are only valid as operands, instruction macros can output arbitrary instructions into the program. This allows users to avoid repetition in their code.