Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty Printing Group Nodes #493

Closed
evamaxfield opened this issue Mar 15, 2018 · 3 comments
Closed

Pretty Printing Group Nodes #493

evamaxfield opened this issue Mar 15, 2018 · 3 comments

Comments

@evamaxfield
Copy link
Collaborator

Currently, when I: print(pkg.group_node)
I am returned something like this:

<GroupNode>
node_0
node_1
node_2
node_3
node_4
node_5
node_6
node_7
node_8
node_9

Where every sub-node is printed.

However, for packages like mine, it isn't uncommon to have hundreds of nodes nested under each other and thus this printing structure isn't the best for viewing.

Two options in my mind:

When I print a group node, have it print a structure like that of the contents section of the webpage preview of a package.
print(pkg.group_node)
Would return:

<GroupNode>
node_0
   subnode_0
      subsubnode_0
      subsubnode_1
   subnode_1
      subsubnode_0
      subsubnode_1
   ...
node_1
   subnode_0
      subsubnode_0
      subsubnode_1
   subnode_1
      subsubnode_0
      subsubnode_1
   ...
...

Or have it print first n and last n subnodes of the node.
print(pkg.group_node)
Would return:

<GroupNode>
node_0
node_1
node_2
...
node_n-2
node_n-1
node_n

Maybe implement both and have a quilt.set_prints('show_depth') / quilt.set_prints('show_length') to indicate which printing method the user wants.

@akarve
Copy link
Member

akarve commented Apr 30, 2018

@JacksonMaxfield does #515 solve this issue?

@evamaxfield
Copy link
Collaborator Author

Yes absolutely!

@akarve akarve closed this as completed Apr 30, 2018
@akarve
Copy link
Member

akarve commented May 10, 2018

Reopening until we resolve some issues with #515

@akarve akarve reopened this May 10, 2018
@akarve akarve closed this as completed Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants