Shortify group nodes representation #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurlov
changed the title
kurlov
force-pushed
the
feature/datanode_prettify
branch
from
21f50ec
to
f28aa33
Compare
|
I looked at panda`s data print, did not find convenient way to change how many rows to show, so I think this feature is not important.
|
kevinemoore
requested changes
Apr 3, 2018
compiler/quilt/nodes.py
Outdated
| # strip last new line if needed | ||
| if items[-1] == '\n': | ||
| items.pop() | ||
| # copare with + 1 helps to prevent hide under '...' only one item |
There was a problem hiding this comment.
Missing the m in compare.
compiler/quilt/nodes.py
Outdated
| @@ -6,7 +6,7 @@ | |||
| import pandas as pd | |||
| from six import iteritems, string_types | |||
|
|
|||
| from .tools import core | |||
| from .tools import core, const | |||
There was a problem hiding this comment.
Maybe just import const.PRETTY_MAX_LEN?
kurlov
force-pushed
the
feature/datanode_prettify
branch
from
f5457a0
to
85c8c4c
Compare
|
@kevinemoore Please, review this PR again. Thanks! |
kevinemoore
approved these changes
Apr 30, 2018
akarve
reviewed
May 9, 2018
| items.append('\n') | ||
| items += sorted(self._data_keys()) | ||
| # strip last new line if needed | ||
| if items[-1] == '\n': |
There was a problem hiding this comment.
This doesn't work for empty nodes
There was a problem hiding this comment.
Whoops, you are right, my bad.
akarve
added a commit
that referenced
this pull request
May 10, 2018
akarve
added a commit
that referenced
this pull request
May 11, 2018
|
Also it prints too many blank newlines in some cases. The PRETTY MAXLEN should also be much larger, like 100.
… On May 11, 2018, at 7:14 AM, Aleksandr Kurlov ***@***.***> wrote:
@kurlov commented on this pull request.
In compiler/quilt/nodes.py:
> @@ -61,11 +62,19 @@ class GroupNode(DataNode):
def __repr__(self):
pinfo = super(GroupNode, self).__repr__()
- group_info = '\n'.join(name + '/' for name in sorted(self._group_keys()))
- if group_info:
- group_info += '\n'
- data_info = '\n'.join(sorted(self._data_keys()))
- return '%s\n%s%s' % (pinfo, group_info, data_info)
+ items = [name + '/' for name in sorted(self._group_keys())]
+ if items:
+ items.append('\n')
+ items += sorted(self._data_keys())
+ # strip last new line if needed
+ if items[-1] == '\n':
Whoops, you are right, my bad.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Shortify nodes printing in case it exceeds limit.
Related to #493