Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CLI command quilt3 disable-telemetry #1496

Merged
merged 3 commits into from
Jan 14, 2020

Conversation

armandmcqueen
Copy link
Contributor

@armandmcqueen armandmcqueen commented Jan 10, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 10, 2020

Codecov Report

Merging #1496 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1496      +/-   ##
==========================================
- Coverage   86.67%   86.62%   -0.06%     
==========================================
  Files          27       27              
  Lines        3573     3581       +8     
==========================================
+ Hits         3097     3102       +5     
- Misses        476      479       +3
Impacted Files Coverage Δ
quilt3/api.py 73.46% <0%> (-0.49%) ⬇️
quilt3/main.py 50.89% <0%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79c3224...b425ac1. Read the comment docs.

api/python/quilt3/main.py Outdated Show resolved Hide resolved
Copy link
Member

@akarve akarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One inline comment and shouldn't we also have "enable" if we're going to disable? OK to merge after addressing inline comment.

Co-Authored-By: Aneesh Karve <akarve@users.noreply.github.com>
@armandmcqueen armandmcqueen merged commit 2940856 into master Jan 14, 2020
@sir-sigurd sir-sigurd deleted the quilt3_cli_disable_telemetry_cmd branch February 25, 2020 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants