Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video preview #2540

Merged
merged 13 commits into from Nov 21, 2021
Merged

Add video preview #2540

merged 13 commits into from Nov 21, 2021

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Nov 18, 2021

Description

TODO

  • Unit tests
  • Automated tests (e.g. Preflight)
  • Documentation
    • JavaScript: basic explanation and screenshot of new features
  • Changelog entry

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #2540 (42ef29b) into master (e08145d) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2540      +/-   ##
==========================================
- Coverage   43.14%   43.07%   -0.08%     
==========================================
  Files         512      514       +2     
  Lines       24524    24569      +45     
  Branches     3293     3301       +8     
==========================================
  Hits        10582    10582              
- Misses      13116    13161      +45     
  Partials      826      826              
Flag Coverage Δ
api-python 90.26% <ø> (ø)
catalog 13.57% <0.00%> (-0.05%) ⬇️
lambda 94.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/Preview/load.js 0.00% <0.00%> (ø)
catalog/app/components/Preview/loaders/Video.tsx 0.00% <0.00%> (ø)
catalog/app/components/Preview/renderers/Video.tsx 0.00% <0.00%> (ø)
catalog/app/components/Preview/renderers/index.js 0.00% <0.00%> (ø)
catalog/app/components/Preview/types.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e08145d...42ef29b. Read the comment docs.

@fiskus fiskus requested a review from nl0 November 18, 2021 18:38
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems cool

catalog/app/components/Preview/types.js Outdated Show resolved Hide resolved
@fiskus fiskus merged commit 9eeacca into master Nov 21, 2021
@fiskus fiskus deleted the video-renderer branch November 21, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants