Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iframe browsing frontend #3198

Merged
merged 133 commits into from Mar 20, 2023
Merged

Iframe browsing frontend #3198

merged 133 commits into from Mar 20, 2023

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Nov 24, 2022 •
edited

  • Added BrowsableIFrameLoader, which is used when bucketConfig.browsable = true
  • Added section Preview file options to Bucket settings and checkbox for browsable

Screenshot from 2023-02-10 15-37-43
Screenshot from 2023-02-10 16-29-20

@codecov
Copy link

codecov bot commented Nov 24, 2022 •
edited

Codecov Report

Merging #3198 (c16328f) into master (8f51583) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3198      +/-   ##
==========================================
- Coverage   35.24%   35.07%   -0.18%     
==========================================
  Files         672      679       +7     
  Lines       29391    29538     +147     
  Branches     4365     4396      +31     
==========================================
  Hits        10360    10360              
- Misses      17851    17987     +136     
- Partials     1180     1191      +11
Flag Coverage Δ
api-python 90.79% <ø> (ø)
catalog 8.90% <0.00%> (-0.07%) ⬇️
lambda 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/Preview/Display.js 0.00% <0.00%> (ø)
catalog/app/components/Preview/loaders/Html.js 0.00% <0.00%> (ø)
.../loaders/IFrame/BrowsableBucketConfig.generated.ts 0.00% <0.00%> (ø)
.../loaders/IFrame/CreateBrowsingSession.generated.ts 0.00% <0.00%> (ø)
...loaders/IFrame/DisposeBrowsingSession.generated.ts 0.00% <0.00%> (ø)
...ponents/Preview/loaders/IFrame/LoaderBrowsable.tsx 0.00% <0.00%> (ø)
...components/Preview/loaders/IFrame/LoaderSigned.tsx 0.00% <0.00%> (ø)
...loaders/IFrame/RefreshBrowsingSession.generated.ts 0.00% <0.00%> (ø)
...log/app/components/Preview/loaders/IFrame/index.ts 0.00% <0.00%> (ø)
catalog/app/components/Preview/types.js 100.00% <ø> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus
remove credentials
d20146b
@fiskus
remove extra type
8e6af91
@fiskus
iframe message bus
491860b
@fiskus
polishing event listeners
3d38e85
@fiskus
Merge branch 'master' of github.com:quiltdata/quilt into iframe-loade…
cb4abf9 
…r-with-environment
@fiskus
add fetchFile and onReady
2aa10ac
@fiskus
rename event names
baa9a5f
@fiskus
use constants instead of strings
2913d53
@fiskus
prettify
662d869
@fiskus
move onMessage to hook and remove unused code
a6880ff
@fiskus
use constatnts
6f7f4d9
@fiskus
fix listener in Chrome, remove debug code
a921f79
@fiskus
Merge branch 'master' of github.com:quiltdata/quilt into iframe-loade…
12cd3fd 
…r-with-environment
@fiskus
add docs
17c490c
@fiskus
Merge branch 'master' of github.com:quiltdata/quilt into iframe-loade…
af02478 
…r-with-environment
@fiskus
fix parallel requests
71f95fd
@fiskus
dry
91ae503
@fiskus
use config
e922fec
@fiskus
todo note
e525791
@fiskus
update docs
067e8ad
@fiskus
update docs with more real life and full example
6d77660
@fiskus
improve docs
141fb30
robnewman
robnewman suggested changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@robnewman robnewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs review only

docs/Catalog/Preview.md Outdated Show resolved Hide resolved
docs/Catalog/Preview.md Outdated Show resolved Hide resolved
docs/Catalog/Preview.md Outdated Show resolved Hide resolved
docs/Catalog/Preview.md Outdated Show resolved Hide resolved
docs/Catalog/Preview.md Outdated Show resolved Hide resolved
docs/Catalog/Preview.md Outdated Show resolved Hide resolved
fiskus and others added 3 commits February 25, 2023 00:46
@fiskus @robnewman
Apply suggestions from code review
1eb9e64 
Co-authored-by: Rob Newman <61608+robnewman@users.noreply.github.com>
@fiskus
Merge branch 'master' of github.com:quiltdata/quilt into iframe-loade…
b137726 
…r-with-environment
@fiskus
lint docs
df2683a
robnewman
robnewman previously approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@robnewman robnewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve once suggested change committed.

docs/Catalog/Preview.md Outdated Show resolved Hide resolved
@nl0
Copy link
Member

nl0 commented Mar 20, 2023

@fiskus let's merge and stage this

@fiskus fiskus merged commit fc8953a into master Mar 20, 2023
38 of 40 checks passed
@fiskus fiskus deleted the iframe-loader-with-environment branch March 20, 2023 15:40
robnewman added a commit that referenced this pull request Apr 6, 2023
@fiskus @robnewman @nl0
Iframe browsing frontend (#3198)
50b8703 
Co-authored-by: Rob Newman <61608+robnewman@users.noreply.github.com>
Co-authored-by: Alexei Mochalov <nl_0@quiltdata.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nl0 nl0 nl0 approved these changes

@robnewman robnewman robnewman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fiskus @nl0 @robnewman