Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iconized/Collapsed variant of collaborators badges for mobile #3307

Merged
merged 5 commits into from Feb 1, 2023

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Jan 31, 2023

Also, fixed hook deps and changelog entry

Before:
Screenshot from 2023-01-31 18-37-49

After:
Screenshot from 2023-01-31 18-37-07

  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #3307 (4295146) into master (60577cd) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3307      +/-   ##
==========================================
- Coverage   35.36%   35.35%   -0.02%     
==========================================
  Files         668      668              
  Lines       29183    29193      +10     
  Branches     4325     4328       +3     
==========================================
  Hits        10321    10321              
- Misses      17689    17698       +9     
- Partials     1173     1174       +1     
Flag Coverage Δ
api-python 90.79% <ø> (ø)
catalog 8.89% <0.00%> (-0.01%) ⬇️
lambda 86.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/components/Collaborators/Avatars.tsx 0.00% <0.00%> (ø)
catalog/app/components/FileEditor/Controls.tsx 0.00% <ø> (ø)
catalog/app/containers/NavBar/Collaborators.tsx 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus requested a review from nl0 February 1, 2023 09:55
@fiskus fiskus merged commit f9c11b5 into master Feb 1, 2023
@fiskus fiskus deleted the minor-fixes branch February 1, 2023 10:57
nl0 added a commit that referenced this pull request Feb 1, 2023
* master:
  Iconized/Collapsed variant of collaborators badges for mobile (#3307)
  Remove the SSO signup page (#3304)
  File edit as text (#3306)
  Update quilt3 in pkgpush lambda (#3303)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants