Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header flash #3487

Merged
merged 4 commits into from Jun 12, 2023
Merged

Fix header flash #3487

merged 4 commits into from Jun 12, 2023

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Jun 12, 2023

  1. Actual fix - apply M.ThemeProvider on upper level, so M.makeStyles uses correct theme
  2. Also corrected M.AppBar background, but it is covered by custom styles anyway
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #3487 (887b278) into master (5ce4d69) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3487      +/-   ##
==========================================
- Coverage   36.15%   36.15%   -0.01%     
==========================================
  Files         684      684              
  Lines       29929    29931       +2     
  Branches     4414     4414              
==========================================
  Hits        10822    10822              
- Misses      17939    17941       +2     
  Partials     1168     1168              
Flag Coverage Δ
api-python 91.35% <ø> (ø)
catalog 10.19% <0.00%> (-0.01%) ⬇️
lambda 86.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/constants/style.js 0.00% <ø> (ø)
catalog/app/containers/NavBar/NavBar.tsx 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus requested a review from nl0 June 12, 2023 12:36
@fiskus fiskus merged commit 978afd4 into master Jun 12, 2023
38 of 40 checks passed
@fiskus fiskus deleted the fix-header-flash branch June 12, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants