Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bookmarks optional (and fix Embed listings) #3705

Merged
merged 2 commits into from Aug 29, 2023
Merged

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Aug 29, 2023

  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #3705 (59d6878) into master (359ca7b) will decrease coverage by 0.03%.
The diff coverage is 7.69%.

@@            Coverage Diff             @@
##           master    #3705      +/-   ##
==========================================
- Coverage   36.08%   36.05%   -0.03%     
==========================================
  Files         681      681              
  Lines       29853    29862       +9     
  Branches     4361     4379      +18     
==========================================
- Hits        10771    10768       -3     
- Misses      17962    17971       +9     
- Partials     1120     1123       +3     
Flag Coverage Δ
api-python 91.35% <ø> (ø)
catalog 9.78% <7.69%> (-0.02%) ⬇️
lambda 86.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
catalog/app/components/Layout/Layout.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Bookmarks/Sidebar.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/File.js 0.00% <0.00%> (ø)
...alog/app/containers/Bucket/Selection/Dashboard.tsx 0.00% <0.00%> (ø)
catalog/app/containers/NavBar/NavBar.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Bookmarks/Provider.tsx 43.28% <100.00%> (-3.20%) ⬇️
catalog/app/containers/Bucket/ListingActions.tsx 96.96% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus enabled auto-merge August 29, 2023 17:11
@fiskus fiskus requested a review from nl0 August 29, 2023 17:11
@fiskus fiskus added this pull request to the merge queue Aug 29, 2023
Merged via the queue into master with commit 56425e7 Aug 29, 2023
38 of 40 checks passed
@fiskus fiskus deleted the bookmarks-are-optional branch August 29, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants