Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Help link to ElasticSearch docs #3861

Merged
merged 1 commit into from Feb 14, 2024
Merged

Search: Help link to ElasticSearch docs #3861

merged 1 commit into from Feb 14, 2024

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Feb 5, 2024

Screenshot from 2024-02-13 16-58-38

  • Documentation
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (af8accf) 36.23% compared to head (f7a5622) 36.23%.

Files Patch % Lines
.../app/containers/NavBar/Suggestions/Suggestions.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3861      +/-   ##
==========================================
- Coverage   36.23%   36.23%   -0.01%     
==========================================
  Files         716      716              
  Lines       31618    31621       +3     
  Branches     4688     4688              
==========================================
  Hits        11457    11457              
- Misses      19005    19008       +3     
  Partials     1156     1156              
Flag Coverage Δ
api-python 91.54% <ø> (ø)
catalog 10.62% <0.00%> (-0.01%) ⬇️
lambda 87.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fiskus fiskus changed the title Search suggestions Search: Help link to ElasticSearch docs Feb 8, 2024
@fiskus fiskus requested a review from nl0 February 8, 2024 18:41
docs/Catalog/SearchQuery.md Outdated Show resolved Hide resolved
catalog/app/containers/NavBar/Suggestions/Suggestions.tsx Outdated Show resolved Hide resolved
@nl0
Copy link
Member

nl0 commented Feb 12, 2024

@akarve wdyt?

@drernie drernie requested a review from akarve February 12, 2024 23:10
akarve
akarve previously requested changes Feb 13, 2024
docs/Catalog/SearchQuery.md Outdated Show resolved Hide resolved
catalog/app/containers/NavBar/Suggestions/Suggestions.tsx Outdated Show resolved Hide resolved
@fiskus
Copy link
Member Author

fiskus commented Feb 13, 2024

  • Updated text
  • Removed extra cruft
  • Adjusted color and padding

@fiskus fiskus requested review from nl0 and akarve February 13, 2024 16:02
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls remove the doc links from the places where they don't make any sense

catalog/app/containers/Search/Search.tsx Outdated Show resolved Hide resolved
catalog/app/containers/Search/Search.tsx Outdated Show resolved Hide resolved
docs/Catalog/SearchQuery.md Outdated Show resolved Hide resolved
docs/Catalog/SearchQuery.md Show resolved Hide resolved
Co-authored-by: Alexei Mochalov <nl_0@quiltdata.io>
@fiskus
Copy link
Member Author

fiskus commented Feb 14, 2024

Done

@fiskus fiskus requested a review from nl0 February 14, 2024 13:10
@fiskus fiskus added this pull request to the merge queue Feb 14, 2024
Merged via the queue into master with commit 0e0e58a Feb 14, 2024
38 of 40 checks passed
@fiskus fiskus deleted the search-suggestions branch February 14, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants