Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject sagas and reducers via HOCs #464

Merged
merged 21 commits into from Mar 13, 2018
Merged

Conversation

nl0
Copy link
Member

@nl0 nl0 commented Mar 5, 2018

Summary:

  • introduce saga and reducer injectors (ported from react-boilerplate)

  • inject sagas and reducers in component composition chain

  • scope reducers and selectors to constant mount points

  • SearchResults: get search string from query

  • various minor refactorings and adjustments, cleanup

@nl0 nl0 force-pushed the saga-reducer-injectors branch 2 times, most recently from d980944 to 34aaa96 Compare March 6, 2018 18:36
@nl0
Copy link
Member Author

nl0 commented Mar 6, 2018

@akarve ready for review

@nl0 nl0 mentioned this pull request Mar 6, 2018
@akarve akarve self-requested a review March 6, 2018 19:17
Copy link
Member

@akarve akarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for merge, will need manual testing post merge. To merge after next catalog release to production.

@akarve
Copy link
Member

akarve commented Mar 10, 2018

@nl0
Copy link
Member Author

nl0 commented Mar 12, 2018

@akarve rebased

@akarve akarve merged commit b6dbc5c into quiltdata:master Mar 13, 2018
@nl0 nl0 deleted the saga-reducer-injectors branch March 13, 2018 08:24
nl0 added a commit that referenced this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants