Fix more s3-proxy bugs #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dimaryaz
commented
Jun 27, 2019
dimaryaz
commented
- Allow whatever method and headers the browser is asking for
- Modify error responses, too (the "always" keyword)
- Allow whatever method and headers the browser is asking for - Modify error responses, too (the "always" keyword)
dimaryaz
force-pushed
the
s3_proxy_headers
branch
from
098ff93
to
e313cfb
Compare
Codecov Report
@@ Coverage Diff @@
## master #912 +/- ##
======================================
Coverage 87.5% 87.5%
======================================
Files 26 26
Lines 3522 3522
======================================
Hits 3082 3082
Misses 440 440Continue to review full report at Codecov.
|
kevinemoore
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.