Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Enable Windows testing #69

Open
drernie opened this issue Oct 11, 2023 · 1 comment
Open

Re-Enable Windows testing #69

drernie opened this issue Oct 11, 2023 · 1 comment

Comments

@drernie
Copy link
Member

drernie commented Oct 11, 2023

  • Could not parse local relative paths correctly (on Windows)
  • Could not disable the test without falling below Coverage threshold
  • Had no way to test locally
  • Needed to focus on getting QuiltSync proof-of-concept (for Mac) by Quilt Retreat
---------------------------- Captured stdout call -----------------------------
Domain.FromURI: file :// d/a/quiltcore/quiltcore/tests/example -> file://d/a/quiltcore/quiltcore/tests/example
Domain.__init__: d/a/quiltcore/quiltcore/tests/example, <Scheme(file)>, {'factory': <Factory(quilt:quilt, {'factory': <Factory(quilt:quilt, {...})@.>})@.>, 'scheme': <Scheme(file:quilt, {'factory': <Factory(quilt:quilt, {'factory': <Factory(quilt:quilt, {...})@.>})@.>, 'scheme': <Scheme(file:quilt, {...})@file>})@file>}
Domain.ToPath: file :// d/a/quiltcore/quiltcore/tests/example
AsPath: d/a/quiltcore/quiltcore/tests/example
AsPath.drives: None
AsPath.key: d/a/quiltcore/quiltcore/tests/example
Domain.store: D:\a\quiltcore\quiltcore\d\a\quiltcore\quiltcore\tests\example
@drernie
Copy link
Member Author

drernie commented Oct 11, 2023

Compare

---------------------------- Captured stdout setup ----------------------------
Domain.__init__: C:\Users\RUNNER~1\AppData\Local\Temp\tmp_rce9y8v, <Scheme(file)>, {'factory': <Factory(quilt:quilt, {'factory': <Factory(quilt:quilt, {...})@.>})@.>, 'scheme': <Scheme(file:quilt, {'factory': <Factory(quilt:quilt, {'factory': <Factory(quilt:quilt, {...})@.>})@.>, 'scheme': <Scheme(file:quilt, {...})@file>})@file>}
Domain.ToPath: file :// C:\Users\RUNNER~1\AppData\Local\Temp\tmp_rce9y8v
AsPath: C:\Users\RUNNER~1\AppData\Local\Temp\tmp_rce9y8v
AsPath.drives: None
AsPath.key: C:\Users\RUNNER~1\AppData\Local\Temp\tmp_rce9y8v
Domain.store: C:\Users\RUNNER~1\AppData\Local\Temp\tmp_rce9y8v

drernie added a commit that referenced this issue Oct 11, 2023
untestable path mangling
#69
drernie added a commit that referenced this issue Oct 11, 2023
* refactor Keyed into udg

pass spec

* Update poetry.lock

* Factory/Schema/Domain

* remove failing tests

* autolint

* test_node_keyed

* fix coverage

keyed
verifiable

* lint ALGEBRA

* self.path

* class Names(Folder)

* stub manifest2

* aggressively verifiable

* def set_dirty

* test_ver

* fix typecheck

* test_node_namespace

* improve names coverage

* entry2

* remove resource

* tutorial

* AUTOLINT

* test remote on win

* update pandas to 2.1

* pull from akarve-komdents

* add Pull

cleanup formatting

* stub domain test

* entry.versionId = self.GetQuery(key, self.cf.K_VER)

* test_pull

* Builder2 + Change

* from .change import Change

* poetry update

* ignore coverage

* pass /skip tests

* remove unused APIs

* Namespace2

* fix gitignore

* fix coverage

* always archive artifacts

* fix tests/example yaml

* sync

* Update ALGEBRA.md

* make clean

* move docs into their own folder

* Create QUILTSYNC.md

* from quiltplus import uri as udi

* fix dead links

* test_pull_udi

* add data_yaml to domain

* test_data

* test_pull_data_yaml

* path.as_posix()

* self.cf.AsStr(path)

For windows

* cleanup debugging

* data-yaml.get_list

* flake8

* domain._status

* poetry run flake8 setup.cfg

* namespace.pull

* ns.pull(man, no_copy=True)

* Table3(Tabular)

* Tabular.init(path)

* header.to_dict4

* class Table4

* make lint

* promote relax

* Read/Write parquet

* fix lint

* Load from Parquet or JSON

* lint

* refactor codec types

* refactor udg Types

* handle localhost file URIs correctly

* test_udi_relative

* standardize AsPath

* UDI.ExpandRelative

* table.relax(f, "tests/example")

* FIRST PARQUET MANIFEST

    with TemporaryDirectory() as tmpdirname:
        f = Path(tmpdirname)
        list4 = table.relax(f, "tests/example")
        Table4.Write4(list4, f / "test.parquet")

* read and write Parquet

* Table4(pout)

* pa.field type

* Store relative (#66)

* pa.field type

* no more relative URIs (just paths)

* remove ExpandRelative

* Tabular.base

* refactor Tabular

* remove relax(prefix)

* remove test_pull_call race condition

* work (or skip) on Windows

* drop vol_post

* stop skipping

* not_win

* refactor OnWindows

* cls.IS_WINDRIVE

* debug Windows

* remove old ToPath

* Disable Windows

untestable path mangling
#69
@drernie drernie changed the title Windows Paths Re-Enable Windows testing Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant