-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pipelines aware of a timezone configuration #249
Open
roelschr
wants to merge
1
commit into
master
Choose a base branch
from
roelschr/add-timezone-config
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
"""FeatureSetPipeline entity.""" | ||
import os | ||
import time | ||
from typing import List | ||
|
||
from butterfree.clients import SparkClient | ||
|
@@ -16,6 +18,8 @@ class FeatureSetPipeline: | |
feature_set: feature set composed by features and context metadata. | ||
sink: sink used to write the output dataframe in the desired locations. | ||
spark_client: client used to access Spark connection. | ||
timezone: timestamp feature transformations will assume this timezone | ||
when they don't have a tz suffix. | ||
Comment on lines
+21
to
+22
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd just inform here that spark con config (spark.sql.session.timeZone) and an env variable (TZ) will be set with this value. |
||
|
||
Example: | ||
This an example regarding the feature set pipeline definition. All | ||
|
@@ -122,11 +126,25 @@ def __init__( | |
feature_set: FeatureSet, | ||
sink: Sink, | ||
spark_client: SparkClient = None, | ||
timezone: str = "UTC", | ||
): | ||
self.source = source | ||
self.feature_set = feature_set | ||
self.sink = sink | ||
self.spark_client = spark_client | ||
self.timezone = timezone | ||
|
||
@property | ||
def timezone(self) -> str: | ||
return self._timezone | ||
|
||
@timezone.setter | ||
def timezone(self, value: str): | ||
if value: | ||
self.spark_client.conn.conf.set("spark.sql.session.timeZone", value) | ||
os.environ["TZ"] = value | ||
time.tzset() | ||
self._timezone = value | ||
|
||
@property | ||
def source(self) -> Source: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
14.4