Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to specify paths values files #92

Closed
renehernandez opened this issue Mar 9, 2021 · 4 comments · Fixed by #104
Closed

Add parameter to specify paths values files #92

renehernandez opened this issue Mar 9, 2021 · 4 comments · Fixed by #104
Assignees

Comments

@renehernandez
Copy link

It would be neat if the plugin supported a --values option that could receive an array of paths pointing to values files that would be passed down to the chart.

That would make easier test against a set of values other than the default values.yaml within the chart folder as well as integrate it with other tools such as hemlfile, which we use to dynamically generate the final set of values that are going to be use to deploy helm-charts.

See related issue in helmfile for extra info: roboll/helmfile#1713

@quintush
Copy link
Owner

Hello @renehernandez,

Thanks for the feedback.
I will start in this, when #91 is solved.

Greetings,
@quintush

@quintush quintush self-assigned this Mar 13, 2021
@renehernandez
Copy link
Author

@quintush I can take look if you are busy

@quintush
Copy link
Owner

Hello @renehernandez,

Besides some validation tests, it already implemented.
Hope to have a pullrequest very soon.

Greetings,
@quintush

@renehernandez
Copy link
Author

Great! Looking forward to the next release

@quintush quintush linked a pull request Mar 23, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants