visual stories ad #384
Merged
visual stories ad #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ags1773
commented
Jun 30, 2022
•
ags1773
commented
- remove bookend code as it's deprecated
- take visual stories ad config as function so Ahead can use it https://github.com/quintype/page-builder/issues/1932
* Add. Cta button for Visual & non Visual stories
Athira001
approved these changes
Jul 12, 2022
snitin4260
approved these changes
Jul 12, 2022
This reverts commit ea0bd83.
This reverts commit ea0bd83.
…into visual-stories-ad
* Add support for logo when themes are added * restructure code * chore(release): 2.4.22-fix-logo-for-themes.1 * Support visual stories as an array and object * chore(release): 2.4.22-fix-logo-for-themes.2 * Update package lock * chore(release): 2.4.22-fix-logo-for-themes.3 * Add fix in component file * update snapshot * chore(release): 2.4.22-fix-logo-for-themes.4 * Remove default null * chore(release): 2.4.22-fix-logo-for-themes.5 * Pick themebased logo and logo from same object * update snapshot * chore(release): 2.4.22-fix-logo-for-themes.6 * chore(release): 2.4.22-fix-logo-for-themes.7 * change variable name and fix bug * Fix bug * chore(release): 2.4.22-fix-logo-for-themes.8 * Remove duplicate code * chore(release): 2.4.22-fix-logo-for-themes.9 * Add get method as defensive check * Restructure code * Restructure code * chore(release): 2.4.22-fix-logo-for-themes.10 * chore(release): 2.4.24-fix-logo-for-themes.0 * Remove switch case * uninstall unused packages * chore(release): 2.4.24-fix-logo-for-themes.1 Co-authored-by: Shraddha Kesari <shraddha@quintype.com>
This reverts commit ea0bd83.
This reverts commit ea0bd83.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.