Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for subscription controller #77

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Add test for subscription controller #77

merged 3 commits into from
Apr 27, 2023

Conversation

44smkn
Copy link
Contributor

@44smkn 44smkn commented Apr 27, 2023 •
edited
Loading

No description provided.

@44smkn 44smkn self-assigned this Apr 27, 2023
@44smkn 44smkn requested review from int128 and pankona April 27, 2023 06:03
pankona
pankona reviewed Apr 27, 2023
View reviewed changes
controllers/subscription_controller_test.go Outdated
)

var _ = Describe("Subscription controller", func() {
Context("When creating a Topic resource", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Topic ではなく Subscription っぽい

pankona
pankona approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@pankona pankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:yoshi:

@44smkn 44smkn marked this pull request as ready for review April 27, 2023 06:06
@44smkn 44smkn force-pushed the 44smkn/add-subscriber-test branch from 2dd09a0 to fdd2310 Compare April 27, 2023 06:18
@44smkn 44smkn merged commit 0b970d8 into main Apr 27, 2023
5 checks passed
@44smkn 44smkn deleted the 44smkn/add-subscriber-test branch April 27, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@int128 int128 int128 approved these changes

@pankona pankona pankona approved these changes

Assignees

@44smkn 44smkn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@44smkn @int128 @pankona