Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure qpc to use or not HTTPS #134

Merged
merged 1 commit into from
Feb 1, 2018
Merged

Configure qpc to use or not HTTPS #134

merged 1 commit into from
Feb 1, 2018

Conversation

elyezer
Copy link
Contributor

@elyezer elyezer commented Feb 1, 2018

Close #132

@elyezer elyezer requested a review from kdelee February 1, 2018 13:40
@coveralls
Copy link

coveralls commented Feb 1, 2018

Coverage Status

Coverage remained the same at 71.154% when pulling 3ebac9a on issues/132 into afcf318 on master.

Copy link
Contributor

@kdelee kdelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I wonder if this is going to be in the config file if we can eschew with the "https: Boolean" part of qcs config

@@ -24,12 +24,19 @@ def qpc_server_config():
port = config.get('qcs', {}).get('port')
username = config.get('qcs', {}).get('username', 'admin')
password = config.get('qcs', {}).get('password', 'pass')
ssl_verify = config.get('qcs', {}).get('ssl-verify', False)
Copy link
Contributor Author

@elyezer elyezer Feb 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may ask about the https value in the config file. The difference is that https controls if the scheme for the URL should be either http or https. ssl-verify on the other hand defines if the connection should be verified or not True/False or if a custom certificate should be used (when the ssl-verify is a path to the certificate file).

The API client can also leverage these two config options to play with adding http or https to the URL and configuring requests' verify argument. So for the API client ssl-verify being false means that we don't want to verify the ssl certificate, true that we want to verify with the certificates available on the system running camayoc and a certificate path to verify and use a custom certificate file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that makes sense!

@elyezer elyezer merged commit 3ebac9a into master Feb 1, 2018
@elyezer elyezer deleted the issues/132 branch February 1, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants