Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test docstrings for Rho tests #45

Merged
merged 1 commit into from
Oct 3, 2017
Merged

Update test docstrings for Rho tests #45

merged 1 commit into from
Oct 3, 2017

Conversation

elyezer
Copy link
Contributor

@elyezer elyezer commented Oct 3, 2017

Add caselevel field and update requirement value. Add Testimony as a dev
requirement and run testimony validate on Travis.

Closes #44

@coveralls
Copy link

coveralls commented Oct 3, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 77.907% when pulling ab35430 on issues/44 into abdbcaf on master.

kdelee
kdelee approved these changes Oct 3, 2017
View reviewed changes
Copy link
Contributor

@kdelee kdelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not got a chance to check this out locally, but LGTM from reading the diff.

Testimony will validate that the test id's are unique?

@elyezer
Copy link
Contributor Author

elyezer commented Oct 3, 2017

@kdelee we will need another script to verify if the IDs are unique. I already have the command and will submit a PR soon

@elyezer
Update test docstrings for Rho tests
3cc7ca6 
Add caselevel field and update requirement value. Add Testimony as a dev
requirement and run `testimony validate` on Travis.

Closes #44
@elyezer
Copy link
Contributor Author

elyezer commented Oct 3, 2017

rebased, will merge after travis being green

@coveralls
Copy link

coveralls commented Oct 3, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 77.907% when pulling 3cc7ca6 on issues/44 into 527c205 on master.

@elyezer elyezer merged commit 3cc7ca6 into master Oct 3, 2017
@elyezer elyezer deleted the issues/44 branch October 3, 2017 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdelee kdelee kdelee approved these changes

@chambridge chambridge Awaiting requested review from chambridge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elyezer @coveralls @kdelee