Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script to validate test docstrings #48

Merged
merged 2 commits into from
Oct 6, 2017
Merged

Add script to validate test docstrings #48

merged 2 commits into from
Oct 6, 2017

Conversation

elyezer
Copy link
Contributor

@elyezer elyezer commented Oct 6, 2017

Closes #46

@coveralls
Copy link

coveralls commented Oct 6, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 77.907% when pulling 35f1c8e on issues/46 into 3cc7ca6 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.907% when pulling 35f1c8e on issues/46 into 3cc7ca6 on master.

@kdelee
Copy link
Contributor

kdelee commented Oct 6, 2017

@elyezer I added a commit to have the make all target also validate the docstrings.

If you like it, I say squash and merge.

kdelee
kdelee approved these changes Oct 6, 2017
View reviewed changes
Copy link
Contributor

@kdelee kdelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than adding this to the make all target

@coveralls
Copy link

coveralls commented Oct 6, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 77.907% when pulling 2cf734c on issues/46 into 3cc7ca6 on master.

@elyezer elyezer merged commit 2cf734c into master Oct 6, 2017
@elyezer elyezer deleted the issues/46 branch October 6, 2017 19:44
@elyezer
Copy link
Contributor Author

elyezer commented Oct 6, 2017

@kdelee I am going to merge the two commits. Thank you for adding that to the all target

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdelee kdelee kdelee approved these changes

@chambridge chambridge Awaiting requested review from chambridge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elyezer @coveralls @kdelee