UI: Update list views when items have 0 count #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-phillips-18
force-pushed
the
issues/690
branch
from
8b6737b
to
a9b4507
Compare
cdcabrera
approved these changes
Feb 23, 2018
There was a problem hiding this comment.
Looking good, as noted by @jeff-phillips-18 minor error pops up, should be fixed in follow up PR.
| if (count > 0) { | ||
| return ( | ||
| <ListView.InfoItem className="list-view-info-item-icon-count"> | ||
| <SimpleTooltip id={`${id}_tip`} tooltip={`${count} ${count === 1 ? tipSingular : tipPlural}`}> |
There was a problem hiding this comment.
Optional: the id string/template literals, looks like the id is always supposed to be a string, we worried about someone jamming a number in there? if so we could just flip tip_${id}
There was a problem hiding this comment.
The propType is string. I could make it accept either, but if you pass an number you do get a console warning but it works OK.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #690