Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

807: formatting, typos, wordsmithing, edit new server install instruc… #924

Merged
merged 2 commits into from
Mar 2, 2018
Merged

807: formatting, typos, wordsmithing, edit new server install instruc… #924

merged 2 commits into from
Mar 2, 2018

Conversation

jlprevatt-zz
Copy link
Contributor

@jlprevatt-zz jlprevatt-zz commented Mar 2, 2018 •
edited
Loading

…tions for beta.rst

Please review the changes. Details are in #807, summary here:

  • fixing formatting (tagging) mostly of the code examples
  • edited new server install steps
  • fixing typos, making corrections, improving wording here and there
  • some deeper wordsmithing on a few sections (e.g., moving log out steps to its own procedure at end)

Closes #807

@jlprevatt-zz jlprevatt-zz requested a review from a team March 2, 2018 19:22
@coveralls
Copy link

coveralls commented Mar 2, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 91.227% when pulling b75fc47 on jlprevatt:807 into e78d34f on quipucords:beta.

chambridge
chambridge reviewed Mar 2, 2018
View reviewed changes
Copy link
Contributor

@chambridge chambridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment.

docs/source/beta.rst Outdated

Listing Scan Results
^^^^^^^^^^^^^^^^^^^^
In addition to showing the status of a single scan, you can also show a list of all scans that are in progress or are completed on the Quipucords server. To show this list of scans, you use the ``scan list`` command. The output of this command includes the scan identifier, the source or sources for that scan, and the current state of the scan.
In addition to showing the status of a single scan, you can also show a list of all scans that are in progress or are completed on the Quipucords server. To show this list of scans, you use the ``scan list`` command. The output of this command includes the scan identifier, the source or sources for that scan, and the current state of the scan:.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ends with the scan:., is that right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, typo from adding the new sentence after that one. Should be fixed with a new commit/push.

chambridge
chambridge approved these changes Mar 2, 2018
View reviewed changes
Copy link
Contributor

@chambridge chambridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlprevatt-zz jlprevatt-zz merged commit f26a6e7 into quipucords:beta Mar 2, 2018
@jlprevatt-zz jlprevatt-zz deleted the 807 branch March 2, 2018 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chambridge chambridge chambridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jlprevatt-zz @coveralls @chambridge @jlprevatt