This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Move RhoCmd to its own file #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall goal: get ready to import JBoss Scanner modules by making our code use different Ansible modules. This commit: one small move towards modularization.
elyezer
reviewed
Jul 7, 2017
|
|
||
| """RhoCmd: a base class with common functionality for our Ansible modules.""" | ||
|
|
||
| import subprocess as sp |
There was a problem hiding this comment.
I usually don't like this kind of renaming because it makes the code harder to understand and will require to check from where this is coming from. But I saw that it was present on the previous code so I think is fine to have this here. But we might want to avoid that in the future.
There was a problem hiding this comment.
I strongly agree about not liking the renaming. I left it to keep this PR simpler, but I would like to go back and change it in the future.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall goal: get ready to import JBoss Scanner modules by making our
code use different Ansible modules.
This commit: one small move towards modularization.