Fix for DataLocationProxy returning null #40
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Aaron,
I ran into an issue when using the DataLocationProxy. The following app would fail with 'path is null'
var app = $.sammy('div.app',function(a){
a.setLocationProxy(new Sammy.DataLocationProxy(this));
a.get('#/',function(){
this.swap('Hello world')
})
});
app.run('#/');
This is because the jQuery data method returns null when there is no data set. The Sammy code expects an empty string to be returned when there is no location set as this is what is returned by the HashChangeProxy. I've updated the DataLocationProxy to return the same as the HashChangeProxy.
Would this be your preferred way of doing things, or should the sammy code (#823 - #824) check for an empty string and null rather than just an empty string?
Cheers
James