Build: turn on babel cache & use babel for TS building #3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this helps in rebuilding in dev-server
MaikoTan
changed the title
quisquous
reviewed
Jul 18, 2021
tsconfig.base.json
Outdated
| // Thanks to babel-loader, we don't need to set it as ES2019. | ||
| // But we need to set it as ES2020 to ensure mocha can run correctly. | ||
| "target": "ES2020", | ||
| "module": "ESNext", |
There was a problem hiding this comment.
What do you get out of ESNext? Mostly wondering why you're adjusting this one as well.
There was a problem hiding this comment.
Currently esnext and es2020 is the same, you mean better to keep it remained?
There was a problem hiding this comment.
Oh, I see. Yeah, I was mostly wondering why you were changing it here. I think I'd rather stick to ES2020 and then change it explicitly when we change it.
quisquous
added a commit
that referenced
this pull request
Sep 26, 2021
This was broken in #3315 when the config files were split up. Even though babel is used with webpack, babel is not used for the triggers branch which is referenced directly by users who are writing their own triggers.
quisquous
added a commit
that referenced
this pull request
Sep 26, 2021
This was broken in #3315 when the config files were split up. Even though babel is used with webpack, babel is not used for the triggers branch which is referenced directly by users who are writing their own triggers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is helpful to enable babel cache when in rebuilding (e.g. running webpack-dev-server), which would significantly decrease the building time.
Although
ts-loader(tscinside) andbabel-loader(babelinside) would basically do the same thing in TypeScript transform,babel-loaderremoves type notations only, and doesn't do the type-checking things, so it would be faster thants-loader(even withtranspileOnlyflag) in most cases. Additionally, we now needbabel-loaderto ensure code available always in Chrome v75 of current CEF, so why not combine them in one loader?Nowadays we are using
fork-ts-checker-webpack-pluginfor type checking, which runstscin a separated process and report errors asynchronously (in production mode), that would not block webpack building (thatts-loaderwill).