Disable plugins which don't work on big endian when targeting BE

This allows us to build on big endian without having to manually disable problematic plugins.
quixdb · Sep 2, 2016 · a83aadf · a83aadf
1 parent 3047884
commit a83aadf
Show file tree

Hide file tree

Showing 8 changed files with 21 additions and 1 deletion.
diff --git a/cmake/SquashPlugin.cmake b/cmake/SquashPlugin.cmake
@@ -1,8 +1,9 @@
 include (AddCompilerFlags)
 include (RequireStandard)
+include (TestBigEndian)
 
 function (SQUASH_PLUGIN)
-  set (options EXTRA_WARNINGS DEFAULT_DISABLED)
+  set (options EXTRA_WARNINGS DEFAULT_DISABLED NO_BIG_ENDIAN)
   set (oneValueArgs NAME EXTERNAL_PKG EXTERNAL_PKG_PREFIX C_STANDARD CXX_STANDARD)
   set (multiValueArgs SOURCES EMBED_SOURCES LIBRARIES LDFLAGS COMPILER_FLAGS EMBED_COMPILER_FLAGS INCLUDE_DIRS EMBED_INCLUDE_DIRS DEFINES EMBED_DEFINES ALLOW_UNDEFINED_DEFINES NO_UNDEFINED_DEFINES EMBED_TARGET)
   cmake_parse_arguments(SQUASH_PLUGIN "${options}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN})
@@ -19,6 +20,14 @@ function (SQUASH_PLUGIN)
     option("ENABLE_${PLUGIN_NAME_UC}" "Enable ${SQUASH_PLUGIN_NAME} plugin" OFF)
   endif ()
 
+  if (ENABLE_${PLUGIN_NAME_UC} AND SQUASH_PLUGIN_NO_BIG_ENDIAN)
+    test_big_endian(squash_plugin_is_be)
+    if(squash_plugin_is_be)
+      message(STATUS "${SQUASH_PLUGIN_NAME} not supported on big endian systems, disabling")
+      return()
+    endif()
+  endif()
+
   if (NOT ENABLE_${PLUGIN_NAME_UC})
     message(STATUS "${SQUASH_PLUGIN_NAME} plugin: disabled")
     return ()

diff --git a/plugins/bsc/CMakeLists.txt b/plugins/bsc/CMakeLists.txt
@@ -3,6 +3,7 @@ include (SquashPlugin)
 squash_plugin (
   NAME bsc
   SOURCES squash-bsc.c
+  NO_BIG_ENDIAN
   EMBED_SOURCES
     libbsc/libbsc/bwt/divsufsort/divsufsort.c
     libbsc/libbsc/adler32/adler32.cpp

diff --git a/plugins/gipfeli/CMakeLists.txt b/plugins/gipfeli/CMakeLists.txt
@@ -2,6 +2,7 @@ include (SquashPlugin)
 
 squash_plugin (
   NAME gipfeli
+  NO_BIG_ENDIAN
   SOURCES squash-gipfeli.cpp
   CXX_STANDARD c++11
   EMBED_SOURCES

diff --git a/plugins/lzfse/CMakeLists.txt b/plugins/lzfse/CMakeLists.txt
@@ -19,6 +19,7 @@ set_compiler_specific_flags(
 
 squash_plugin (
   NAME lzfse
+  NO_BIG_ENDIAN
   SOURCES squash-lzfse.c
   C_STANDARD c99
   EMBED_SOURCES

diff --git a/plugins/lzma/CMakeLists.txt b/plugins/lzma/CMakeLists.txt
@@ -94,6 +94,11 @@ else ()
   list (APPEND lzma_embed_defines MYTHREAD_POSIX)
 endif ()
 
+test_big_endian(LZMA_IS_BIG_ENDIAN)
+if(LZMA_IS_BIG_ENDIAN)
+  list (APPEND lzma_embed_defines "WORDS_BIGENDIAN")
+endif(LZMA_IS_BIG_ENDIAN)
+
 find_package(LZMA)
 
 squash_plugin (

diff --git a/plugins/ncompress/CMakeLists.txt b/plugins/ncompress/CMakeLists.txt
@@ -2,5 +2,6 @@ include (SquashPlugin)
 
 squash_plugin (
   NAME ncompress
+  NO_BIG_ENDIAN
   SOURCES squash-ncompress.c
   EMBED_SOURCES compress.c)
diff --git a/plugins/wflz/CMakeLists.txt b/plugins/wflz/CMakeLists.txt
@@ -2,6 +2,7 @@ include (SquashPlugin)
 
 squash_plugin (
   NAME wflz
+  NO_BIG_ENDIAN
   SOURCES squash-wflz.c
   EMBED_SOURCES wflz/wfLZ.c
   NO_UNDEFINED_DEFINES

diff --git a/plugins/zling/CMakeLists.txt b/plugins/zling/CMakeLists.txt
@@ -2,6 +2,7 @@ include (SquashPlugin)
 
 squash_plugin (
   NAME zling
+  NO_BIG_ENDIAN
   SOURCES squash-zling.cpp
   EMBED_SOURCES
     libzling/src/libzling.cpp