Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix include file order #148

Closed
wants to merge 1 commit into from
Closed

Fix include file order #148

wants to merge 1 commit into from

Conversation

jibsen
Copy link
Collaborator

@jibsen jibsen commented Oct 24, 2015

MSVC 2013 required strsafe.h to be included after tchar.h.

MSVC 2013 required strsafe.h to be included after tchar.h.
@nemequ
Copy link
Member

nemequ commented Oct 31, 2015

Should we add a VS 2013 entry to AppVeyor?

Obviously I don't have any problem with this patch; just let me know when you want me to merge.

@jibsen
Copy link
Collaborator Author

jibsen commented Oct 31, 2015

Should we add a VS 2013 entry to AppVeyor?

Might be a good idea. It appears there are some changes like snprintf (ffd2c45) and this that can break builds.

Obviously I don't have any problem with this patch; just let me know when you want me to merge.

Please do.

@nemequ
Copy link
Member

nemequ commented Oct 31, 2015

Might be a good idea. It appears there are some changes like snprintf (ffd2c45) and this that can break builds.

Done.

Please do.

Merged, thanks.

@nemequ nemequ closed this Oct 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants