Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a libdeflate plugin #183

Closed
wants to merge 1 commit into from
Closed

Add a libdeflate plugin #183

wants to merge 1 commit into from

Conversation

jrmuizel
Copy link

No description provided.

@nemequ
Copy link
Member

nemequ commented Jan 28, 2016

Looks good, just a few minor portability issues.

I've filed ebiggers/libdeflate#3 to get the build working with MSVC. Other than that, it looks like the other compilers can be fixed by enabling C99 mode, see the density plugin for an example.

Don't worry about clang-3.7 or ICC… ICC doesn't work with pull requests (encrypted data doesn't work in PRs, so ICC doesn't get a serial number and refuses to install) so don't worry about that, and the failure with clang 3.7 seems unrelated (I'll look into that as soon as I have some time).

@nemequ
Copy link
Member

nemequ commented Jan 28, 2016

Looks like we'll just have to disable the plugin in appveyor for now since it might take a while to fix.

Also, I just noticed that the codec name in the documentation is "libdeflate" instead of "deflate".

@jrmuizel
Copy link
Author

I've updated the documentation and added C99 mode

@nemequ
Copy link
Member

nemequ commented Jan 28, 2016

Looks like the name of the codec in the squash.ini file is "libdeflate", but the plugin expects "deflate". Assuming they're compatible with zlib's deflate codec, they should both be "deflate"

@jrmuizel
Copy link
Author

Should be fixed now.

@nemequ
Copy link
Member

nemequ commented Jan 29, 2016

Merged, thanks!

@nemequ nemequ closed this Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants