Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from_dataframe() cannot handle complex numbers #55

Closed
JotaBlanco opened this issue Mar 6, 2023 · 3 comments
Closed

from_dataframe() cannot handle complex numbers #55

JotaBlanco opened this issue Mar 6, 2023 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@JotaBlanco
Copy link

Tell us about the bug
from_dataframe() breaks when dealing with columns with complex numbers:

`---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
in

in from_dataframe(data_frame, epoch)
111 isnumeric = (label_type == int or label_type == float or label_type == complex)
112 if isnumeric:
--> 113 if math.isnan(content):
114 continue # ignore it, as panda uses NaN instead of None, unable to detect difference
115 if panda_col_label.startswith('TAG__'): # in case user of lib didn't put it in quote don't throw err

TypeError: can't convert complex to float`

@peter-quix
Copy link
Contributor

Please provide a code sample that can be used to reproduce the issue,

Also, are those line numbers provided by your IDE for the lib's codebase or some version of it that you use? I can't match it with any source code we have.

@JotaBlanco
Copy link
Author

hey @peter-quix, yep I was using a notebook for some of these tests. You can find it here: https://github.com/quixio/quix-streams-to_dataframe_tests/blob/main/src/PythonClient/tests/quixstreams/manual/from_dataframe.ipynb

@peter-quix peter-quix added bug Something isn't working good first issue Good for newcomers labels Mar 26, 2023
@peter-quix
Copy link
Contributor

No longer relevant, new python code is not working the same way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Development

No branches or pull requests

2 participants