Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Improvement - from_dataframe() -> 'TimeseriesDataRaw': #53

Closed
JotaBlanco opened this issue Mar 3, 2023 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@JotaBlanco
Copy link

I understand that in streaming is quite uncommon to have big chunks (batches) of data been publish, so a long dataframe with lots or rows is unlikely.
Anyhow, right now the dataframe to TimeseriesDataRaw conversion is done by row and column, which is inefficient. I'll be proposing a new vectorized version to improve speed (specially with big dataframes).

@peter-quix peter-quix added the enhancement New feature or request label Mar 3, 2023
@JotaBlanco
Copy link
Author

Ok, interesting, I've been playing with a vectorized version of the existing from_dataframe() and this is what I've found:

  • My new code is much faster with big dataframes (above ~250 rows) and much slower with smaller dataframes.
    image

  • Given that most messages will have a low number of rows (streaming data, not batches of data), I think the current code should stay.

  • I still like to share my vectorized version for future reference, what's the best way? @peter-quix

  • Whilst doing this exercise, I found two bugs that need solving:

@JotaBlanco
Copy link
Author

tim-quix pushed a commit that referenced this issue Nov 14, 2023
* [feat] - add getting started to landing page

* [fix] - title

* [fix] - APIs should not have an apostrophe for plural
@peter-quix
Copy link
Contributor

No longer relevant, new python code is not working the same way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants