Native improvements 4 - Renaming and event signature changes #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename ParameterBuffer and related to TimeseriesBuffer
* Apply renaming of variables where needed * Rename ExceptionOccurred to OnExceptionOccurred
* rename SubscriberConfiguration to ConsumerConfiguration
* Rename StartReading to Subscribe * Rename Write/Send to Publish
* Handle no partition info by throwing exception * Properly (well hackily) implement no consumer group for QuixStreamingClient * Fix python integration tests
SteveRosam
approved these changes
Feb 22, 2023
peter-quix
added a commit
that referenced
this pull request
Feb 22, 2023
Breaking changes * Added input_topic to all stream events (such as parameters.on_read, on_raw_read, definitions change, same for events and properties). * Renamed ParameterData -> TimeseriesData and ParameterBuffer -> TimeseriesBuffer and related classes * Renamed IOutput, IInput to IConsumer and IProducer in Transport layer. * Renamed ExceptionOccurred to OnExceptionOccurred * Renamed KafkaReader/Writer to TelemetryKafkaConsumer/Producer * Renamed Input/OutputTopic to TopicConsumer/Producer. * Renamed StartReading to Subscribe * Renamed Write/Send to Publish * Renamed SDK -> Streams and Quix Streams depending on context * Default consumer group is no longer "Default" and AutoOffsetReset is set to Latest rather than Earliest Other: * Docs updated to reflect changes above * Apply renaming of variables where needed * Deleted some invalid/outdated docs regarding local setup * Moved Quix topic/consumer logic from KafkaStreamingClient to QuixStreamingClient * Now handling exceptions in callbacks when a user doesn't do exception handling. Helps to detect bad callback signatures and similar * Handle no partition info by throwing exception rather than silently failing when no consumer group is in use * Cleanup Usings in C# and imports in Python
tim-quix
pushed a commit
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
Other: