Add CONTRIBUTING.md #207
Merged
Add CONTRIBUTING.md #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TenninYan
reviewed
Feb 24, 2020
CONTRIBUTING.md
Outdated
| ### Tips | ||
|
|
||
| - We only check the format in Linux | ||
| so Travis CI could point out some format errors even if there is nothing error in your Windows or macOS. |
There was a problem hiding this comment.
We only check the format in Linux.
Travis CI could point out format errors even if there are no errors in your Windows or macOS.
が正しい英語かなー？
There was a problem hiding this comment.
Would it be better to use there is no error instead of there are no errors?
There was a problem hiding this comment.
Sorry for my very very late fix 🙇
|
LGTM! |
heliac2000
pushed a commit
to heliac2000/qulacs
that referenced
this pull request
Aug 21, 2020
Add CONTRIBUTING.md
m-ymzk
added a commit
to m-ymzk/qulacs
that referenced
this pull request
Apr 16, 2023
[Refactoring] named-gateのOpenMP関係の関数を共通化
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make,mate test,make pythontest,python setup.py installetc...CONTRIBUTING.mdwhich says the way how to bulid, format (Add formatter #201 ) and test.CONTRIBUTING.mdor not 🤔