Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C++ Example Compile Commands in Docs #246

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Fix C++ Example Compile Commands in Docs #246

merged 2 commits into from
Aug 21, 2020

Conversation

kotamanegi
Copy link
Contributor

This PR fix C++ example compile commands in document to work correctly.

I think C++ example compile commands written in document and readme is outdated, and does not work.
So I fixed example commands to work as expected.

kwkbtr and others added 2 commits June 22, 2020 18:23
Since the original C++ compile command written in Docs was not working correctly, I fixed Docs to work.
@corryvrequan
Copy link
Contributor

Thanks, @kotamanegi . I also checked the updated command works.
Since almost all the users use python, many parts of C++ examples and tutorials may be outdated or unchecked. Sorry for inconvenience.

@corryvrequan corryvrequan merged commit 838b7ef into qulacs:dev Aug 21, 2020
@kotamanegi kotamanegi deleted the Document-C++BuildUsage-Fix branch September 3, 2020 07:56
kotamanegi pushed a commit to kotamanegi/qulacs that referenced this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants