Fix C++ library compile issues and guides #248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the following two issues:
C++ library compile issues
In Eigen 3.3.5 with CUDA, a lot of Eigen users report that compile errors happen in Eigen/Half.h file.
This qulacs C++ library is being affected by this issue.
So, I tried updating version to Eigen 3.3.5 -> 3.3.7, which Eigen maintainers say that the issue has been removed.
I manually checked that this solution passes tests.
Usage guide of C++ with CUDA
When we use nvcc, we need to add many compile options compared to non-GPU qulacs.
Therefore, I think it is essential to add usage guide on documents.