Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C++ library compile issues and guides #248

Merged
merged 5 commits into from
Oct 12, 2020
Merged

Fix C++ library compile issues and guides #248

merged 5 commits into from
Oct 12, 2020

Conversation

kotamanegi
Copy link
Contributor

This PR fix the following two issues:

  1. C++ library compile issues
    In Eigen 3.3.5 with CUDA, a lot of Eigen users report that compile errors happen in Eigen/Half.h file.
    This qulacs C++ library is being affected by this issue.
    So, I tried updating version to Eigen 3.3.5 -> 3.3.7, which Eigen maintainers say that the issue has been removed.
    I manually checked that this solution passes tests.

  2. Usage guide of C++ with CUDA
    When we use nvcc, we need to add many compile options compared to non-GPU qulacs.
    Therefore, I think it is essential to add usage guide on documents.

Added detailed information about using qulacs library with C++ sourcecode.
on nvcc compile file should be .cu , not .cpp
@corryvrequan
Copy link
Contributor

Sorry for bothering you with out-of-date documents, and thanks for updating our documents.
The updated documents seem correct and nice!

@corryvrequan corryvrequan merged commit 9f3817d into qulacs:dev Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants