Fix CI on mac; upload built wheel files as CI artifacts #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@y-yu Please review 🙏 |
kotamanegi
added a commit
to kotamanegi/qulacs
that referenced
this pull request
Jun 14, 2022
…pr-185 PR#185からリファクタリングの変更を取り込む
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GitHub Actions virtual environment macos-10.15/20201115.1, linking some functions from libgomp fails since the linker cannot find some library files from gcc-8 installed via Homebrew.
Failure example: https://github.com/qulacs/qulacs/runs/1462123962?check_suite_focus=true#step:10:165
Added a command that fixes this issue by (brew) re-linking files from gcc-8.
cf. https://stackoverflow.com/a/55500164
Also added a setting to upload built wheel files as CI artifacts so that we can download and test them on local machines before publishing to PyPI.