Skip to content
This repository has been archived by the owner on Jul 6, 2021. It is now read-only.

API: Documents QUnit.skip #77

Closed
wants to merge 3 commits into from
Closed

Conversation

leobalter
Copy link
Member

@leobalter leobalter added this to the 1.16 milestone Sep 11, 2014
</argument>
</signature>
<desc>
Add a WIP test, it will be skipped and will also ignore any hooks.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not use abbreviations like "WIP" in documentation. This also needs some explanation of why anyone would use this method, along with a two way reference to QUnit.test().

@jzaefferer
Copy link
Member

Cross-repo references need to use "[user]/[repo]#[issue]", for example "Ref qunitjs/qunit#652"

<argument name="name" type="String">
<desc>Title of unit being tested</desc>
</argument>
<argument name="test">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this line should be:

<argument name="test" type="Function" optional="true">

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also make it more explicit like QUnit.test's documentation were we document the Function format but that would be kind of ironic since we totally disregard the function passed in anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove it entirely, that would reflect the actual implementation.

@leobalter
Copy link
Member Author

some changes applied.

Adds a test like object to be skipped
</desc>
<longdesc>
<p>This test's prototype will be listed on the suite as a skipped test, ignoring a giving callback function and the respective global and module's hooks.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "ignoring the callback argument"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also "Use this method to replace QUnit.test instead of commenting out entire tests." (make the reference a link)

@jzaefferer
Copy link
Member

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Document QUnit.skip
3 participants