Skip to content

Commit

Permalink
Build: Add Node 18 to matrix, update default to Node 16
Browse files Browse the repository at this point in the history
Some generic jobs were still using a default of Node 10 or 14.
  • Loading branch information
Krinkle committed Oct 22, 2022
1 parent 49b20d3 commit 5eb231d
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 15 deletions.
15 changes: 10 additions & 5 deletions .github/workflows/CI.yaml
Expand Up @@ -11,6 +11,11 @@ jobs:
fail-fast: false
matrix:
include:
- name: "Linux: Node 18"
os: ubuntu-20.04
node: 18.x
script: npm run test-nolint

- name: "Linux: Node 16"
# Includes 'firefox', 'chromium', and more.
# https://github.com/actions/virtual-environments/blob/ubuntu20/20220410.2/images/linux/Ubuntu2004-Readme.md
Expand Down Expand Up @@ -38,7 +43,7 @@ jobs:

- name: "Integration"
os: ubuntu-20.04
node: 14.x
node: 16.x
script: npm run test-integration

- name: "Windows: Node 16"
Expand Down Expand Up @@ -68,7 +73,7 @@ jobs:
key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}

- name: Use Node.js ${{ matrix.node }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3.5.0
with:
node-version: ${{ matrix.node }}

Expand Down Expand Up @@ -107,10 +112,10 @@ jobs:
~/.npm
${{ github.workspace }}/.puppeteer_download
key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
- name: Use Node.js 10
uses: actions/setup-node@v2
- name: Use Node.js 16
uses: actions/setup-node@v3.5.0
with:
node-version: 10.x
node-version: 16.x
- name: Install mozjs
run: |
sudo apt-fast install -y libmozjs-68-dev
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/browsers-full.yaml
Expand Up @@ -27,10 +27,10 @@ jobs:
${{ github.workspace }}/.puppeteer_download
key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}

- name: Use Node.js 10
uses: actions/setup-node@v2
- name: Use Node.js 16
uses: actions/setup-node@v3.5.0
with:
node-version: 10.x
node-version: 16.x

- name: Prepare
run: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/browsers-quick.yaml
Expand Up @@ -19,10 +19,10 @@ jobs:
${{ github.workspace }}/.puppeteer_download
key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}

- name: Use Node.js 14
uses: actions/setup-node@v2
- name: Use Node.js 16
uses: actions/setup-node@v3.5.0
with:
node-version: 14.x
node-version: 16.x

- name: Prepare
run: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/coverage.yaml
Expand Up @@ -19,10 +19,10 @@ jobs:
${{ github.workspace }}/.puppeteer_download
key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}

- name: Use Node.js 14
uses: actions/setup-node@v2
- name: Use Node.js 16
uses: actions/setup-node@v3.5.0
with:
node-version: 14.x
node-version: 16.x

- run: npm ci

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reproducible.yaml
Expand Up @@ -19,7 +19,7 @@ jobs:
- uses: actions/checkout@v2

- name: Use Node.js 16
uses: actions/setup-node@v2
uses: actions/setup-node@v3.5.0
with:
node-version: 16.x

Expand Down

0 comments on commit 5eb231d

Please sign in to comment.