Skip to content

Commit

Permalink
Make filters case-insensitive. Partial fix for #252
Browse files Browse the repository at this point in the history
  • Loading branch information
jzaefferer committed May 31, 2012
1 parent 697ee6e commit a4eeba4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions qunit/qunit.js
Expand Up @@ -1007,8 +1007,8 @@ function done() {

function validTest( test ) {
var include,
filter = config.filter,
fullName = test.module + ": " + test.testName;
filter = config.filter.toLowerCase(),
fullName = (test.module + ": " + test.testName).toLowerCase();

if ( config.testNumber ) {
return test.testNumber === config.testNumber;
Expand Down

2 comments on commit a4eeba4

@mholt
Copy link

@mholt mholt commented on a4eeba4 May 31, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I think this broke it. Try the example runner file at http://docs.jquery.com/QUnit, but instead of using the qunit.js file referenced there, use the contents of this commit. "Cannot call toLowerCase() on undefined".

@jzaefferer
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was rather stupid. Thanks @mholt - fixed in a297b95

Please sign in to comment.