-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate HTML runner and HTML reporter? #1118
Comments
I like this, and note also the (loosely) related #947. |
I'm looking into this as part of #1486, and running into an obstacle with For QUnit's own use, we could trivially generate a different set of IDs (e.g. lazily, from the testStart event). For plugins, we may need to change it so that the plugin reacts to the HTML rather than influencing it from the inside. For example, the way a plugin finds the HTML element currently is via (contextual) Straw-man proposal:
Challenges this brings about:
Perhaps it's not worth separating the two, but we could still add support for disabling the bulk of the output and running a plain text CRI reporter in its place. In any event, that could of course be a good first step either way. |
Used by HTML Reporter, and by plugins such as `steal-qunit`. Ref qunitjs#1118
Used by HTML Reporter, and by plugins such as `steal-qunit`. Ref #1118
As prep to extract a reporter-agnostic "HTML Runner" from the HTML Reporter, move the `urlparams.js` import out of html.js. It is important (and covered by `test/reporter-html/hidepassed.html`) that the `QUnit.begin()` callback in urlparams.js continues to run before the one in html.js. When only moving the import statement, this breaks because diff.js was also importing html.js for re-use of the `escapeText` function. As such the order in reporter.js was not what it appeared. It appeared as: - fixture - diff - html - urlparams But was actually: - fixture - diff - html - urlparams - html (redundant) Ref #1118
(Ditching the issue template since this is a meta-issue)
Now that we're working on a QUnit Node CLI and integrating with js-reporters, I think we need to see if we can refactor the HTML Reporter space to split that into HTML "runner" and HTML "reporter".
Conceptually, here is what I would like to see long-term:
The text was updated successfully, but these errors were encountered: