Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commander to 7.1.0 #1564

Closed
4 tasks done
Krinkle opened this issue Mar 14, 2021 · 2 comments · Fixed by #1565
Closed
4 tasks done

Update commander to 7.1.0 #1564

Krinkle opened this issue Mar 14, 2021 · 2 comments · Fixed by #1565

Comments

@Krinkle
Copy link
Member

Krinkle commented Mar 14, 2021

Update commander from 6.2.1 to 7.1.0 (latest).

Release notes:

Commits: https://github.com/tj/commander.js/commits/v7.1.0

  • Verify publication to npm, use npm info commander@6.2.1 and npm info commander@7.1.0.
  • Review package diffs, use npm diff ---diff commander@6.2.1 --diff commander@7.1.0 --color=always | less -R (since npm 7) or https://diff.intrinsic.com.
  • Repeat the above two steps for any changed or added indirect dependencies.
  • What feature(s) is this package used for: CLI options parsing.
    • Prepare update in a PR and locally interact with the related features.
@Krinkle
Copy link
Member Author

Krinkle commented Mar 14, 2021

Verify publication to npm

Previously at #1546

commander@6.2.1 | MIT | deps: none | …

maintainers:
- zhiyelee <zhiyelee@gmail.com>
- somekittens <rkoutnik@gmail.com>
- tjholowaychuk <tj@vision-media.ca>
- vanesyan <romain.vanesyan@gmail.com>
- shadowspawn <npm_j@ruru.gen.nz>
- abetomo <abe@enzou.tokyo>
$ npm info commander@7.1.0

commander@7.1.0 | MIT | deps: none

maintainers:
- zhiyelee <zhiyelee@gmail.com>
- somekittens <rkoutnik@gmail.com>
- tjholowaychuk <tj@vision-media.ca>
- vanesyan <romain.vanesyan@gmail.com>
- shadowspawn <npm_j@ruru.gen.nz>
- abetomo <abe@enzou.tokyo>


published 3 weeks ago by abetomo <abe@enzou.tokyo>
  • ✅ Published by the same account as a previous release: Yes.
  • ✅ New maintainer(s): (none).
  • ✅ Added ependencies: (none)
  • ✅ Changed dependencies: (none)

@Krinkle
Copy link
Member Author

Krinkle commented Mar 14, 2021

Review package diffs

  • Drop support for Node 6-9, requires Node 10+ (That's okay, we also require Node 10+)
  • Options are now accessed via the objected returned from program.opts() instead of on program itself.
  • Internal refactoring and removal of deprecated methods that we didn't use.

✅ LGTM.

Krinkle added a commit to Krinkle/qunit that referenced this issue Mar 14, 2021
Krinkle added a commit that referenced this issue Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant